1.优化
Showing
3 changed files
with
14 additions
and
10 deletions
... | @@ -550,9 +550,7 @@ public class TaskOperationServiceImpl implements TaskOperationService { | ... | @@ -550,9 +550,7 @@ public class TaskOperationServiceImpl implements TaskOperationService { |
550 | ).collect(toList()); | 550 | ).collect(toList()); |
551 | 551 | ||
552 | // 没有满足条件的数据 | 552 | // 没有满足条件的数据 |
553 | if (CollectionUtils.isEmpty(taskStream)) { | 553 | if (!CollectionUtils.isEmpty(taskStream)) { |
554 | return false; | ||
555 | } else { | ||
556 | 554 | ||
557 | // 验证会员分组 | 555 | // 验证会员分组 |
558 | boolean result1 = this.validatedMemberGroup(memberId,taskList); | 556 | boolean result1 = this.validatedMemberGroup(memberId,taskList); |
... | @@ -561,10 +559,17 @@ public class TaskOperationServiceImpl implements TaskOperationService { | ... | @@ -561,10 +559,17 @@ public class TaskOperationServiceImpl implements TaskOperationService { |
561 | 559 | ||
562 | // 获取当前任务的完成情况 | 560 | // 获取当前任务的完成情况 |
563 | boolean result = this.checkAndRefreshTaskCompletion(memberId,taskList); | 561 | boolean result = this.checkAndRefreshTaskCompletion(memberId,taskList); |
562 | |||
564 | return result; | 563 | return result; |
564 | |||
565 | } else { | ||
566 | |||
567 | return false; | ||
568 | |||
565 | } | 569 | } |
566 | 570 | ||
567 | }; | 571 | }; |
572 | |||
568 | return compareTaskCondition.compareCondition(memberDTO,taskList); | 573 | return compareTaskCondition.compareCondition(memberDTO,taskList); |
569 | } | 574 | } |
570 | 575 | ||
... | @@ -812,7 +817,7 @@ public class TaskOperationServiceImpl implements TaskOperationService { | ... | @@ -812,7 +817,7 @@ public class TaskOperationServiceImpl implements TaskOperationService { |
812 | 817 | ||
813 | DataSyncMsg.MsgData msgData = dataSyncMsg.getMsg(); | 818 | DataSyncMsg.MsgData msgData = dataSyncMsg.getMsg(); |
814 | 819 | ||
815 | if (Objects.nonNull(msgData)) { | 820 | if (Objects.nonNull(msgData.getParam())) { |
816 | 821 | ||
817 | String param = msgData.getParam(); | 822 | String param = msgData.getParam(); |
818 | Map<String,String> jsonObjectMap = JSONObject.parseObject(param,Map.class); | 823 | Map<String,String> jsonObjectMap = JSONObject.parseObject(param,Map.class); |
... | @@ -896,7 +901,7 @@ public class TaskOperationServiceImpl implements TaskOperationService { | ... | @@ -896,7 +901,7 @@ public class TaskOperationServiceImpl implements TaskOperationService { |
896 | private TaskTemplate getTaskTemplate(Integer event,DataSyncMsg msgData) { | 901 | private TaskTemplate getTaskTemplate(Integer event,DataSyncMsg msgData) { |
897 | DataSyncMsg.MsgData msg = msgData.getMsg(); | 902 | DataSyncMsg.MsgData msg = msgData.getMsg(); |
898 | 903 | ||
899 | if (Objects.nonNull(msg)) { | 904 | if (Objects.nonNull(msg.getParam())) { |
900 | 905 | ||
901 | return this.findByTypeAndParam(event,msg); | 906 | return this.findByTypeAndParam(event,msg); |
902 | 907 | ... | ... |
... | @@ -23,10 +23,11 @@ public class TaskOperationControllerTest extends BaseTest { | ... | @@ -23,10 +23,11 @@ public class TaskOperationControllerTest extends BaseTest { |
23 | DataSyncMsg dataSyncMsg = new DataSyncMsg(); | 23 | DataSyncMsg dataSyncMsg = new DataSyncMsg(); |
24 | dataSyncMsg.setEventType(EventType.VIEWING.name()); | 24 | dataSyncMsg.setEventType(EventType.VIEWING.name()); |
25 | DataSyncMsg.MsgData msgData = new DataSyncMsg.MsgData(); | 25 | DataSyncMsg.MsgData msgData = new DataSyncMsg.MsgData(); |
26 | msgData.setEvent(6); // 类型 1-登录 2-观影 3-参加活动 4-订购 5-优享会员 6-签到 | 26 | msgData.setEvent(2); // 类型 1-登录 2-观影 3-参加活动 4-订购 5-优享会员 6-签到 |
27 | msgData.setRemarks("remark"); | 27 | msgData.setRemarks("remark"); |
28 | msgData.setMemberId(2261L); | 28 | msgData.setMemberId(20592L); |
29 | msgData.setDeviceType(2); | 29 | // 1:大屏;2:小屏(微信)3.小屏(xx) |
30 | msgData.setDeviceType(1); | ||
30 | msgData.setAppCode("WEI_XIN_GOLD_PANDA"); | 31 | msgData.setAppCode("WEI_XIN_GOLD_PANDA"); |
31 | dataSyncMsg.setMsg(msgData); | 32 | dataSyncMsg.setMsg(msgData); |
32 | String s = JSON.toJSONString(dataSyncMsg); | 33 | String s = JSON.toJSONString(dataSyncMsg); | ... | ... |
-
Please register or sign in to post a comment